Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy-authentication headers for Python 3.* and long basic credential encodings #562

Conversation

paulmayer
Copy link
Contributor

@paulmayer paulmayer commented Feb 2, 2025

Fixes #540
Fixes #517

Note:

  1. Tested with 2.7 and 3.7+
  2. Tried to use module-local conventions (e.g. unittest/pytest)
  3. I'm using impala quickstarter (4.4.1) for local test execution, no hive tests executed
  4. impala.tests.test_dbapi_connect.ImpalaConnectionTests.test_retry_dml generally fails for me (and failed also before making any modifcations)

Copy link
Collaborator

@csringhofer csringhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the fix and tests!

@csringhofer
Copy link
Collaborator

csringhofer commented Feb 5, 2025

impala.tests.test_dbapi_connect.ImpalaConnectionTests.test_retry_dml generally fails for me (and failed also before making any modifcations)

I wrote test_retry_dml in a hurry and it is not surprising that it is flaky - practically it relies on Impala's non local catalog's slowness due to statestore's low update frequency. I will try to rework it to be more reliable.

I'm using impala quickstarter (4.4.1) for local test execution, no hive tests executed

Can you give more info on the env? What is exactly impala quickstarter? :)

@csringhofer
Copy link
Collaborator

@paulmayer
Created a PR to make test_retry_dml more reliable by using a Impala debug action to trigger the timeout:
#566
Tested it with legacy and local catalog Impala (on local catalog it was failing before the patch) and checked that allowing retries during ExecuteStatement leads to failing the test.
Can you check if it is green is your environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants